Removed import instructions of deprecated numpy functions - cast, product#90
Merged
Removed import instructions of deprecated numpy functions - cast, product#90
Conversation
mrakitin
approved these changes
Mar 10, 2026
Contributor
mrakitin
left a comment
mrakitin
left a comment
There was a problem hiding this comment.
Per https://github.com/numpy/numpy/pull/10653/changes, we'll use np.prod which was used in that implementation of np.product.
Contributor
|
We'll need to update the CI to pass, but we can do it after the move to the NSLS2 org. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cast and product are not any longer supperted in numpy 2.3.5 ('current' kernel) . Luckily, they were not used in the pyCHX code as dicovered by @jmaruland
Also, added a simple import test. I think it's hard time we start testing more than 1+1=2 with future releases. This is just a first small step.